Ensure touch events are properly handled for pageX and pageY #15587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: c7398f3...497e937 react-events
Generated by 🚫 dangerJS |
necolas
reviewed
May 8, 2019
packages/react-events/src/Press.js
Outdated
| if (touchEvents.length === 0) { | ||
| throw new Error('TouchEvent does not have any changed touches'); | ||
| } | ||
| // TODO: we need to support multi-touch in the future, this is a temp |
There was a problem hiding this comment.
How does multi-touch related to Press?
There was a problem hiding this comment.
As we discussed in our meeting, we need to consider the user pressing multiple Press event responders at the same time. I'll address this TODO tomorrow in a follow up.
| }); | ||
| }); | ||
|
|
||
| describe('press with movement (touch events fallback)', () => { |
There was a problem hiding this comment.
It's a little difficult to follow what happened in this part of the diff. Is this duplicating the entire pointer events test block? If so, I don't think we need to do that (and we don't for mouse events)
There was a problem hiding this comment.
It doesn't duplicate it all, a lot of it, but I changed a few tests too and remove a few there were mouse related.
necolas
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working with an iOS device, I noticed that we were incorrectly trying to access the co-ords for
pageXandpageYon thenativeEventobject. They don't exist in this place, rather this change makes it so we access them on thechangedTouchesarray (if it exists). We only take them from the first event, we need to add support multiple touches in the future.Ref #15257